Update on ThresholdAdjuster.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Update on ThresholdAdjuster.java

Philippe CARL
Dear all (probably mostly Wayne)

Under the following link:

http://punias.free.fr/ImageJ/ThresholdAdjuster.java

I have put a modified version of the ThresholdAdjuster.java file where I
added MouseWheelListener features to the minSlider and maxSlider.

The reason why I did this, is that it is sometimes quite difficult to
concentrate (at least for a starting to be old man like I very unfortunately
do) on the picture threshold actions while simultaneously playing with the
sliders via mouse button actions.

With this new code, you just click once on a given slider (minSlider or
maxSlider) and then just forget it by only using the mouse wheel to increase
or decrease its value and thus just concentrate on the given threshold
changes within the given picture.

I’m also thinking to add as well the left/right arrow keys for making the
same actions but would first like to get your opinion on this.

Besides that, I have another question (but maybe it is very stupid) about
the thresholder window (while I’m working on it).

Indeed why is there a “Set” window for setting the Lower and Upper Threshold
Level?

Wouldn’t it be better or easier to simply transform the indicator values
next to the minSlider or maxSlider to TextFields where the user could then
just simply write the new wished values? (and if there is no objections on
this I will write the needed code…)

Looking forward for your comments and/or critics on all this I wish you a
nice day (I hope as well sunny for you).

My best regards,

Philippe

 

Philippe CARL

Laboratoire de Biophotonique et Pharmacologie

UMR 7213 CNRS - Université de Strasbourg

Faculté de Pharmacie

74 route du Rhin

67401 ILLKIRCH

Tel : +33(0)3 68 85 41 84


--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html
Reply | Threaded
Open this post in threaded view
|

Re: Update on ThresholdAdjuster.java

Wayne Rasband-2
> On Sep 27, 2017, at 8:05 AM, Philippe CARL <[hidden email]> wrote:
>
> Dear all (probably mostly Wayne)
>
> Under the following link:
>
> http://punias.free.fr/ImageJ/ThresholdAdjuster.java
>
> I have put a modified version of the ThresholdAdjuster.java file where I
> added MouseWheelListener features to the minSlider and maxSlider.

These modifications are in the latest ImageJ daily build (1.51r13).

> The reason why I did this, is that it is sometimes quite difficult to
> concentrate (at least for a starting to be old man like I very unfortunately
> do) on the picture threshold actions while simultaneously playing with the
> sliders via mouse button actions.
>
> With this new code, you just click once on a given slider (minSlider or
> maxSlider) and then just forget it by only using the mouse wheel to increase
> or decrease its value and thus just concentrate on the given threshold
> changes within the given picture.
>
> I’m also thinking to add as well the left/right arrow keys for making the
> same actions but would first like to get your opinion on this.

Arrow key support is a good idea, especially on Macs, where scrollbars are missing buttons for incrementing/decrementing by one.

> Besides that, I have another question (but maybe it is very stupid) about
> the thresholder window (while I’m working on it).
>
> Indeed why is there a “Set” window for setting the Lower and Upper Threshold
> Level?
>
> Wouldn’t it be better or easier to simply transform the indicator values
> next to the minSlider or maxSlider to TextFields where the user could then
> just simply write the new wished values? (and if there is no objections on
> this I will write the needed code…)

It would probably be better to display the min and max values in editable text fields.

-wayne

> Looking forward for your comments and/or critics on all this I wish you a
> nice day (I hope as well sunny for you).
>
> My best regards,
>
> Philippe
>
>
>
> Philippe CARL
>
> Laboratoire de Biophotonique et Pharmacologie
>
> UMR 7213 CNRS - Université de Strasbourg
>
> Faculté de Pharmacie
>
> 74 route du Rhin
>
> 67401 ILLKIRCH
>
> Tel : +33(0)3 68 85 41 84

--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html
Reply | Threaded
Open this post in threaded view
|

Re: Update on ThresholdAdjuster.java

Philippe CARL
Dear Wayne,
I thank you very much for your update, but in the same time I'm a little bit sorry since your update very probably crossed further updates I finalized yesterday evening.
Indeed, on the update you can now find under the same following link:
http://punias.free.fr/ImageJ/ThresholdAdjuster.java
I finalized all the wishes I had described within my previous mail.
This means that I replaced the min/max threshold values labels by editable TextFields which new values can now be validated once the user hits the enter key. And given this new feature, the "Set" button isn't needed anymore and I got thus rid of it.
Besides that, the left/right keys decrease/increase the threshold values in the case the cursor is within one of these editable TextFields.
And small detail, I set the name of these TextFields to minLabel and maxLabel which seemed more consistent than the previous label1 and label2.
I already tested this new code against a couple old macro codes and send it as well to three collegues in my laboratory for debugging and din't find any issues. But maybe there are issues i didn't think about.
Thus if you or somebody within this list finds some bugs within these updates, please inform me abut them.
Have a nice week-end,
Philippe

Le Samedi 30 Septembre 2017 07:24 CEST, Wayne Rasband <[hidden email]> a écrit:

> > On Sep 27, 2017, at 8:05 AM, Philippe CARL <[hidden email]> wrote:
> >
> > Dear all (probably mostly Wayne)
> >
> > Under the following link:
> >
> > http://punias.free.fr/ImageJ/ThresholdAdjuster.java
> >
> > I have put a modified version of the ThresholdAdjuster.java file where I
> > added MouseWheelListener features to the minSlider and maxSlider.
>
> These modifications are in the latest ImageJ daily build (1.51r13).
>
> > The reason why I did this, is that it is sometimes quite difficult to
> > concentrate (at least for a starting to be old man like I very unfortunately
> > do) on the picture threshold actions while simultaneously playing with the
> > sliders via mouse button actions.
> >
> > With this new code, you just click once on a given slider (minSlider or
> > maxSlider) and then just forget it by only using the mouse wheel to increase
> > or decrease its value and thus just concentrate on the given threshold
> > changes within the given picture.
> >
> > I’m also thinking to add as well the left/right arrow keys for making the
> > same actions but would first like to get your opinion on this.
>
> Arrow key support is a good idea, especially on Macs, where scrollbars are missing buttons for incrementing/decrementing by one.
>
> > Besides that, I have another question (but maybe it is very stupid) about
> > the thresholder window (while I’m working on it).
> >
> > Indeed why is there a “Set” window for setting the Lower and Upper Threshold
> > Level?
> >
> > Wouldn’t it be better or easier to simply transform the indicator values
> > next to the minSlider or maxSlider to TextFields where the user could then
> > just simply write the new wished values? (and if there is no objections on
> > this I will write the needed code…)
>
> It would probably be better to display the min and max values in editable text fields.
>
> -wayne
>
> > Looking forward for your comments and/or critics on all this I wish you a
> > nice day (I hope as well sunny for you).
> >
> > My best regards,
> >
> > Philippe
> >
> >
> >
> > Philippe CARL
> >
> > Laboratoire de Biophotonique et Pharmacologie
> >
> > UMR 7213 CNRS - Université de Strasbourg
> >
> > Faculté de Pharmacie
> >
> > 74 route du Rhin
> >
> > 67401 ILLKIRCH
> >
> > Tel : +33(0)3 68 85 41 84
>
> --
> ImageJ mailing list: http://imagej.nih.gov/ij/list.html





--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html
Reply | Threaded
Open this post in threaded view
|

Re: Update on ThresholdAdjuster.java

Philippe CARL
In reply to this post by Philippe CARL
Dear Wayne,
I thank you very much for your update, but in the same time I'm a little bit sorry since your update very probably crossed further updates I finalized yesterday evening.
Indeed, on the update you can now find under the same following link:
http://punias.free.fr/ImageJ/ThresholdAdjuster.java
I finalized all the wishes I had described within my previous mail.
This means that I replaced the min/max threshold values labels by editable TextFields which new values can now be validated once the user hits the enter key. And given this new feature, the "Set" button isn't needed anymore and I got thus rid of it.
Besides that, the left/right keys decrease/increase the threshold values in the case the cursor is within one of these editable TextFields.
And small detail, I set the name of these TextFields to minLabel and maxLabel which seemed more consistent than the previous label1 and label2.
I already tested this new code against a couple old macro codes and send it as well to three collegues in my laboratory for debugging and din't find any issues. But maybe there are issues i didn't think about.
Thus if you or somebody within this list finds some bugs within these updates, please inform me abut them.
Have a nice week-end,
Philippe

Le Samedi 30 Septembre 2017 07:24 CEST, Wayne Rasband <[hidden email]> a écrit:

> > On Sep 27, 2017, at 8:05 AM, Philippe CARL <[hidden email]> wrote:
> >
> > Dear all (probably mostly Wayne)
> >
> > Under the following link:
> >
> > http://punias.free.fr/ImageJ/ThresholdAdjuster.java
> >
> > I have put a modified version of the ThresholdAdjuster.java file where I
> > added MouseWheelListener features to the minSlider and maxSlider.
>
> These modifications are in the latest ImageJ daily build (1.51r13).
>
> > The reason why I did this, is that it is sometimes quite difficult to
> > concentrate (at least for a starting to be old man like I very unfortunately
> > do) on the picture threshold actions while simultaneously playing with the
> > sliders via mouse button actions.
> >
> > With this new code, you just click once on a given slider (minSlider or
> > maxSlider) and then just forget it by only using the mouse wheel to increase
> > or decrease its value and thus just concentrate on the given threshold
> > changes within the given picture.
> >
> > I’m also thinking to add as well the left/right arrow keys for making the
> > same actions but would first like to get your opinion on this.
>
> Arrow key support is a good idea, especially on Macs, where scrollbars are missing buttons for incrementing/decrementing by one.
>
> > Besides that, I have another question (but maybe it is very stupid) about
> > the thresholder window (while I’m working on it).
> >
> > Indeed why is there a “Set” window for setting the Lower and Upper Threshold
> > Level?
> >
> > Wouldn’t it be better or easier to simply transform the indicator values
> > next to the minSlider or maxSlider to TextFields where the user could then
> > just simply write the new wished values? (and if there is no objections on
> > this I will write the needed code…)
>
> It would probably be better to display the min and max values in editable text fields.
>
> -wayne
>
> > Looking forward for your comments and/or critics on all this I wish you a
> > nice day (I hope as well sunny for you).
> >
> > My best regards,
> >
> > Philippe
> >
> >
> >
> > Philippe CARL
> >
> > Laboratoire de Biophotonique et Pharmacologie
> >
> > UMR 7213 CNRS - Université de Strasbourg
> >
> > Faculté de Pharmacie
> >
> > 74 route du Rhin
> >
> > 67401 ILLKIRCH
> >
> > Tel : +33(0)3 68 85 41 84
>
> --
> ImageJ mailing list: http://imagej.nih.gov/ij/list.html











--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html
Reply | Threaded
Open this post in threaded view
|

Re: Update on ThresholdAdjuster.java

Wayne Rasband-2
> On Sep 30, 2017, at 6:52 AM, CARL Philippe (PHA) <[hidden email]> wrote:
>
> Dear Wayne,
> I thank you very much for your update, but in the same time I'm a little bit sorry since your update very probably crossed further updates I finalized yesterday evening.
> Indeed, on the update you can now find under the same following link:
> http://punias.free.fr/ImageJ/ThresholdAdjuster.java
> I finalized all the wishes I had described within my previous mail.
> This means that I replaced the min/max threshold values labels by editable TextFields which new values can now be validated once the user hits the enter key. And given this new feature, the "Set" button isn't needed anymore and I got thus rid of it.
> Besides that, the left/right keys decrease/increase the threshold values in the case the cursor is within one of these editable TextFields.

Hi Philippe,

These updates, which work well, are in the latest ImageJ daily build (1.51r15).

-wayne


> And small detail, I set the name of these TextFields to minLabel and maxLabel which seemed more consistent than the previous label1 and label2.
> I already tested this new code against a couple old macro codes and send it as well to three collegues in my laboratory for debugging and din't find any issues. But maybe there are issues i didn't think about.
> Thus if you or somebody within this list finds some bugs within these updates, please inform me abut them.
> Have a nice week-end,
> Philippe
>
> Le Samedi 30 Septembre 2017 07:24 CEST, Wayne Rasband <[hidden email]> a écrit:
>
>>> On Sep 27, 2017, at 8:05 AM, Philippe CARL <[hidden email]> wrote:
>>>
>>> Dear all (probably mostly Wayne)
>>>
>>> Under the following link:
>>>
>>> http://punias.free.fr/ImageJ/ThresholdAdjuster.java
>>>
>>> I have put a modified version of the ThresholdAdjuster.java file where I
>>> added MouseWheelListener features to the minSlider and maxSlider.
>>
>> These modifications are in the latest ImageJ daily build (1.51r13).
>>
>>> The reason why I did this, is that it is sometimes quite difficult to
>>> concentrate (at least for a starting to be old man like I very unfortunately
>>> do) on the picture threshold actions while simultaneously playing with the
>>> sliders via mouse button actions.
>>>
>>> With this new code, you just click once on a given slider (minSlider or
>>> maxSlider) and then just forget it by only using the mouse wheel to increase
>>> or decrease its value and thus just concentrate on the given threshold
>>> changes within the given picture.
>>>
>>> I’m also thinking to add as well the left/right arrow keys for making the
>>> same actions but would first like to get your opinion on this.
>>
>> Arrow key support is a good idea, especially on Macs, where scrollbars are missing buttons for incrementing/decrementing by one.
>>
>>> Besides that, I have another question (but maybe it is very stupid) about
>>> the thresholder window (while I’m working on it).
>>>
>>> Indeed why is there a “Set” window for setting the Lower and Upper Threshold
>>> Level?
>>>
>>> Wouldn’t it be better or easier to simply transform the indicator values
>>> next to the minSlider or maxSlider to TextFields where the user could then
>>> just simply write the new wished values? (and if there is no objections on
>>> this I will write the needed code…)
>>
>> It would probably be better to display the min and max values in editable text fields.
>>
>> -wayne
>>
>>> Looking forward for your comments and/or critics on all this I wish you a
>>> nice day (I hope as well sunny for you).
>>>
>>> My best regards,
>>>
>>> Philippe

--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html
Reply | Threaded
Open this post in threaded view
|

Re: Update on ThresholdAdjuster.java

lechristophe
Hi,

These are very nice improvements. As they would be very useful there (and
would help maintaining a coherent GUI), could they be ported to the B&C
(brightness and contrast) settings window? The mousewheel listener could
also be useful in other settings window such as the gamma window.

Thanks,

Christophe

On Mon, Oct 2, 2017 at 2:46 AM, Wayne Rasband <[hidden email]> wrote:

> > On Sep 30, 2017, at 6:52 AM, CARL Philippe (PHA) <
> [hidden email]> wrote:
> >
> > Dear Wayne,
> > I thank you very much for your update, but in the same time I'm a little
> bit sorry since your update very probably crossed further updates I
> finalized yesterday evening.
> > Indeed, on the update you can now find under the same following link:
> > http://punias.free.fr/ImageJ/ThresholdAdjuster.java
> > I finalized all the wishes I had described within my previous mail.
> > This means that I replaced the min/max threshold values labels by
> editable TextFields which new values can now be validated once the user
> hits the enter key. And given this new feature, the "Set" button isn't
> needed anymore and I got thus rid of it.
> > Besides that, the left/right keys decrease/increase the threshold values
> in the case the cursor is within one of these editable TextFields.
>
> Hi Philippe,
>
> These updates, which work well, are in the latest ImageJ daily build
> (1.51r15).
>
> -wayne
>
>
> > And small detail, I set the name of these TextFields to minLabel and
> maxLabel which seemed more consistent than the previous label1 and label2.
> > I already tested this new code against a couple old macro codes and send
> it as well to three collegues in my laboratory for debugging and din't find
> any issues. But maybe there are issues i didn't think about.
> > Thus if you or somebody within this list finds some bugs within these
> updates, please inform me abut them.
> > Have a nice week-end,
> > Philippe
> >
> > Le Samedi 30 Septembre 2017 07:24 CEST, Wayne Rasband <[hidden email]>
> a écrit:
> >
> >>> On Sep 27, 2017, at 8:05 AM, Philippe CARL <[hidden email]>
> wrote:
> >>>
> >>> Dear all (probably mostly Wayne)
> >>>
> >>> Under the following link:
> >>>
> >>> http://punias.free.fr/ImageJ/ThresholdAdjuster.java
> >>>
> >>> I have put a modified version of the ThresholdAdjuster.java file where
> I
> >>> added MouseWheelListener features to the minSlider and maxSlider.
> >>
> >> These modifications are in the latest ImageJ daily build (1.51r13).
> >>
> >>> The reason why I did this, is that it is sometimes quite difficult to
> >>> concentrate (at least for a starting to be old man like I very
> unfortunately
> >>> do) on the picture threshold actions while simultaneously playing with
> the
> >>> sliders via mouse button actions.
> >>>
> >>> With this new code, you just click once on a given slider (minSlider or
> >>> maxSlider) and then just forget it by only using the mouse wheel to
> increase
> >>> or decrease its value and thus just concentrate on the given threshold
> >>> changes within the given picture.
> >>>
> >>> I’m also thinking to add as well the left/right arrow keys for making
> the
> >>> same actions but would first like to get your opinion on this.
> >>
> >> Arrow key support is a good idea, especially on Macs, where scrollbars
> are missing buttons for incrementing/decrementing by one.
> >>
> >>> Besides that, I have another question (but maybe it is very stupid)
> about
> >>> the thresholder window (while I’m working on it).
> >>>
> >>> Indeed why is there a “Set” window for setting the Lower and Upper
> Threshold
> >>> Level?
> >>>
> >>> Wouldn’t it be better or easier to simply transform the indicator
> values
> >>> next to the minSlider or maxSlider to TextFields where the user could
> then
> >>> just simply write the new wished values? (and if there is no
> objections on
> >>> this I will write the needed code…)
> >>
> >> It would probably be better to display the min and max values in
> editable text fields.
> >>
> >> -wayne
> >>
> >>> Looking forward for your comments and/or critics on all this I wish
> you a
> >>> nice day (I hope as well sunny for you).
> >>>
> >>> My best regards,
> >>>
> >>> Philippe
>
> --
> ImageJ mailing list: http://imagej.nih.gov/ij/list.html
>

--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html
Reply | Threaded
Open this post in threaded view
|

Re: Update on ThresholdAdjuster.java

Philippe CARL
Dear Christophe,
Your point is absolutely correct and in the meanwhile I thought as well about it.
I would even push it further since similar updates could as well be applied to most Process->Filters tools making them more user friendly to use. But in the same time such updates are raising questions which I think the community should answer.
Indeed let's take as example the Process->Filters->Gaussian_Blur... tool.
Of how much should the increase/decrease value be? Of 1 pixel? Of 0.1 Pixel?
Should then such increment value be a variable parameter that could be set within a Edit->Options feature?
Also for the B&C (brightness and contrast) settings window (which is probably one of the most used by people) a similar update raises the question on how to deal with the "Unsigned 16-bit range" and "Propagate to all other open pictures" options which are found within the "set" option.
Can these two options simply be integrated within the main window or may this raise some issues?
If such updates are making no harm (i.e. may not break already existing macro or other languages code) and find the agreement of people here, I can move forward to work on them to submit them to Wayne.
My best regards,
Philippe

-----Message d'origine-----
De : ImageJ Interest Group [mailto:[hidden email]] De la part de Christophe Leterrier
Envoyé : lundi 2 octobre 2017 12:01
À : [hidden email]
Objet : Re: Update on ThresholdAdjuster.java

Hi,

These are very nice improvements. As they would be very useful there (and would help maintaining a coherent GUI), could they be ported to the B&C (brightness and contrast) settings window? The mousewheel listener could also be useful in other settings window such as the gamma window.

Thanks,

Christophe

On Mon, Oct 2, 2017 at 2:46 AM, Wayne Rasband <[hidden email]> wrote:

> > On Sep 30, 2017, at 6:52 AM, CARL Philippe (PHA) <
> [hidden email]> wrote:
> >
> > Dear Wayne,
> > I thank you very much for your update, but in the same time I'm a
> > little
> bit sorry since your update very probably crossed further updates I
> finalized yesterday evening.
> > Indeed, on the update you can now find under the same following link:
> > http://punias.free.fr/ImageJ/ThresholdAdjuster.java
> > I finalized all the wishes I had described within my previous mail.
> > This means that I replaced the min/max threshold values labels by
> editable TextFields which new values can now be validated once the
> user hits the enter key. And given this new feature, the "Set" button
> isn't needed anymore and I got thus rid of it.
> > Besides that, the left/right keys decrease/increase the threshold
> > values
> in the case the cursor is within one of these editable TextFields.
>
> Hi Philippe,
>
> These updates, which work well, are in the latest ImageJ daily build
> (1.51r15).
>
> -wayne
>
>
> > And small detail, I set the name of these TextFields to minLabel and
> maxLabel which seemed more consistent than the previous label1 and label2.
> > I already tested this new code against a couple old macro codes and
> > send
> it as well to three collegues in my laboratory for debugging and din't
> find any issues. But maybe there are issues i didn't think about.
> > Thus if you or somebody within this list finds some bugs within
> > these
> updates, please inform me abut them.
> > Have a nice week-end,
> > Philippe
> >
> > Le Samedi 30 Septembre 2017 07:24 CEST, Wayne Rasband
> > <[hidden email]>
> a écrit:
> >
> >>> On Sep 27, 2017, at 8:05 AM, Philippe CARL
> >>> <[hidden email]>
> wrote:
> >>>
> >>> Dear all (probably mostly Wayne)
> >>>
> >>> Under the following link:
> >>>
> >>> http://punias.free.fr/ImageJ/ThresholdAdjuster.java
> >>>
> >>> I have put a modified version of the ThresholdAdjuster.java file
> >>> where
> I
> >>> added MouseWheelListener features to the minSlider and maxSlider.
> >>
> >> These modifications are in the latest ImageJ daily build (1.51r13).
> >>
> >>> The reason why I did this, is that it is sometimes quite difficult
> >>> to concentrate (at least for a starting to be old man like I very
> unfortunately
> >>> do) on the picture threshold actions while simultaneously playing
> >>> with
> the
> >>> sliders via mouse button actions.
> >>>
> >>> With this new code, you just click once on a given slider
> >>> (minSlider or
> >>> maxSlider) and then just forget it by only using the mouse wheel
> >>> to
> increase
> >>> or decrease its value and thus just concentrate on the given
> >>> threshold changes within the given picture.
> >>>
> >>> I’m also thinking to add as well the left/right arrow keys for
> >>> making
> the
> >>> same actions but would first like to get your opinion on this.
> >>
> >> Arrow key support is a good idea, especially on Macs, where
> >> scrollbars
> are missing buttons for incrementing/decrementing by one.
> >>
> >>> Besides that, I have another question (but maybe it is very
> >>> stupid)
> about
> >>> the thresholder window (while I’m working on it).
> >>>
> >>> Indeed why is there a “Set” window for setting the Lower and Upper
> Threshold
> >>> Level?
> >>>
> >>> Wouldn’t it be better or easier to simply transform the indicator
> values
> >>> next to the minSlider or maxSlider to TextFields where the user
> >>> could
> then
> >>> just simply write the new wished values? (and if there is no
> objections on
> >>> this I will write the needed code…)
> >>
> >> It would probably be better to display the min and max values in
> editable text fields.
> >>
> >> -wayne
> >>
> >>> Looking forward for your comments and/or critics on all this I
> >>> wish
> you a
> >>> nice day (I hope as well sunny for you).
> >>>
> >>> My best regards,
> >>>
> >>> Philippe
>
> --
> ImageJ mailing list: http://imagej.nih.gov/ij/list.html
>

--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html

--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html
Reply | Threaded
Open this post in threaded view
|

Re: Update on ThresholdAdjuster.java

Philippe CARL
In reply to this post by lechristophe
Dear Wayne,
I have already made the code implementing the mouse wheel listener on all the 4 sliders of the B&C window.
And to push further the implementation, I thought about inspiring (I mean from the form) from the Threshold window with a bigger plot and the labels next to the sliders.
But I completely agree with you that we should rather wait until other users are interested by such updates before pushing things further on other tools (given especially that up to now this topic was mostly only a discussion between you and me).
Nevertheless, for the Process>Filters tools having preview options you could as well add me within the people interested by either mouse wheel and/or left/right arrows features additions.
Kindest regards,
Philippe

-----Message d'origine-----
De : Wayne Rasband [mailto:[hidden email]]
Envoyé : mardi 3 octobre 2017 04:52
À : CARL Philippe (PHA)
Objet : Re: Update on ThresholdAdjuster.java

Dear Philippe,

> On Oct 2, 2017, at 7:20 AM, Philippe CARL <[hidden email]> wrote:
>
> Dear Christophe,
> Your point is absolutely correct and in the meanwhile I thought as well about it.
> I would even push it further since similar updates could as well be applied to most Process->Filters tools making them more user friendly to use. But in the same time such updates are raising questions which I think the community should answer.
> Indeed let's take as example the Process->Filters->Gaussian_Blur... tool.
> Of how much should the increase/decrease value be? Of 1 pixel? Of 0.1 Pixel?

You should probably wait to see if there is user demand for this. It is not obvious how useful these updates would be with the commands in the Process>Filters menu.

> Should then such increment value be a variable parameter that could be set within a Edit->Options feature?
> Also for the B&C (brightness and contrast) settings window (which is probably one of the most used by people) a similar update raises the question on how to deal with the "Unsigned 16-bit range" and "Propagate to all other open pictures" options which are found within the "set" option.
> Can these two options simply be integrated within the main window or may this raise some issues?

It would probably be best, and easiest, to just keep the “Set” button.

Best regards,

-wayne

> If such updates are making no harm (i.e. may not break already existing macro or other languages code) and find the agreement of people here, I can move forward to work on them to submit them to Wayne.
> My best regards,
> Philippe
>
> -----Message d'origine-----
> De : ImageJ Interest Group [mailto:[hidden email]] De la part de
> Christophe Leterrier Envoyé : lundi 2 octobre 2017 12:01 À :
> [hidden email] Objet : Re: Update on ThresholdAdjuster.java
>
> Hi,
>
> These are very nice improvements. As they would be very useful there (and would help maintaining a coherent GUI), could they be ported to the B&C (brightness and contrast) settings window? The mousewheel listener could also be useful in other settings window such as the gamma window.
>
> Thanks,
>
> Christophe
>
> On Mon, Oct 2, 2017 at 2:46 AM, Wayne Rasband <[hidden email]> wrote:
>
>>> On Sep 30, 2017, at 6:52 AM, CARL Philippe (PHA) <
>> [hidden email]> wrote:
>>>
>>> Dear Wayne,
>>> I thank you very much for your update, but in the same time I'm a
>>> little
>> bit sorry since your update very probably crossed further updates I
>> finalized yesterday evening.
>>> Indeed, on the update you can now find under the same following link:
>>> http://punias.free.fr/ImageJ/ThresholdAdjuster.java
>>> I finalized all the wishes I had described within my previous mail.
>>> This means that I replaced the min/max threshold values labels by
>> editable TextFields which new values can now be validated once the
>> user hits the enter key. And given this new feature, the "Set" button
>> isn't needed anymore and I got thus rid of it.
>>> Besides that, the left/right keys decrease/increase the threshold
>>> values
>> in the case the cursor is within one of these editable TextFields.
>>
>> Hi Philippe,
>>
>> These updates, which work well, are in the latest ImageJ daily build
>> (1.51r15).
>>
>> -wayne
>>
>>
>>> And small detail, I set the name of these TextFields to minLabel and
>> maxLabel which seemed more consistent than the previous label1 and label2.
>>> I already tested this new code against a couple old macro codes and
>>> send
>> it as well to three collegues in my laboratory for debugging and
>> din't find any issues. But maybe there are issues i didn't think about.
>>> Thus if you or somebody within this list finds some bugs within
>>> these
>> updates, please inform me abut them.
>>> Have a nice week-end,
>>> Philippe
>>>
>>> Le Samedi 30 Septembre 2017 07:24 CEST, Wayne Rasband
>>> <[hidden email]>
>> a écrit:
>>>
>>>>> On Sep 27, 2017, at 8:05 AM, Philippe CARL
>>>>> <[hidden email]>
>> wrote:
>>>>>
>>>>> Dear all (probably mostly Wayne)
>>>>>
>>>>> Under the following link:
>>>>>
>>>>> http://punias.free.fr/ImageJ/ThresholdAdjuster.java
>>>>>
>>>>> I have put a modified version of the ThresholdAdjuster.java file
>>>>> where
>> I
>>>>> added MouseWheelListener features to the minSlider and maxSlider.
>>>>
>>>> These modifications are in the latest ImageJ daily build (1.51r13).
>>>>
>>>>> The reason why I did this, is that it is sometimes quite difficult
>>>>> to concentrate (at least for a starting to be old man like I very
>> unfortunately
>>>>> do) on the picture threshold actions while simultaneously playing
>>>>> with
>> the
>>>>> sliders via mouse button actions.
>>>>>
>>>>> With this new code, you just click once on a given slider
>>>>> (minSlider or
>>>>> maxSlider) and then just forget it by only using the mouse wheel
>>>>> to
>> increase
>>>>> or decrease its value and thus just concentrate on the given
>>>>> threshold changes within the given picture.
>>>>>
>>>>> I’m also thinking to add as well the left/right arrow keys for
>>>>> making
>> the
>>>>> same actions but would first like to get your opinion on this.
>>>>
>>>> Arrow key support is a good idea, especially on Macs, where
>>>> scrollbars
>> are missing buttons for incrementing/decrementing by one.
>>>>
>>>>> Besides that, I have another question (but maybe it is very
>>>>> stupid)
>> about
>>>>> the thresholder window (while I’m working on it).
>>>>>
>>>>> Indeed why is there a “Set” window for setting the Lower and Upper
>> Threshold
>>>>> Level?
>>>>>
>>>>> Wouldn’t it be better or easier to simply transform the indicator
>> values
>>>>> next to the minSlider or maxSlider to TextFields where the user
>>>>> could
>> then
>>>>> just simply write the new wished values? (and if there is no
>> objections on
>>>>> this I will write the needed code…)
>>>>
>>>> It would probably be better to display the min and max values in
>> editable text fields.
>>>>
>>>> -wayne
>>>>
>>>>> Looking forward for your comments and/or critics on all this I
>>>>> wish
>> you a
>>>>> nice day (I hope as well sunny for you).
>>>>>
>>>>> My best regards,
>>>>>
>>>>> Philippe
>>
>> --
>> ImageJ mailing list: http://imagej.nih.gov/ij/list.html
>>
>
> --
> ImageJ mailing list: http://imagej.nih.gov/ij/list.html
>
> --
> ImageJ mailing list: http://imagej.nih.gov/ij/list.html

--
ImageJ mailing list: http://imagej.nih.gov/ij/list.html